New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@leav/ui):Open and close the record's value details depending on where the user clicks #712

Merged

philippechevieux merged 1 commit into develop from feat/XSTREAM-1125-SaturdayNightFeverSidePanel

Jan 22, 2025

Collaborator

philippechevieux commented Jan 16, 2025 •

edited

Loading

Checklist

Definition Of Review

Own code review done (add notes for others)

Write message in teams channel

 <Title>

*️⃣ Impacted projects : Core - DataStudio - Admin - @leav/ui - @leav/utils - ...

📖 Ticket: https://aristid.atlassian.net/browse/<JIRA_TICKET_IDENTIFIER>

🧑‍💻 PR: <link to PR/MR>

ℹ Info: <brief explanation - context - how to test>

Definition Of Mergeable

2 approves
1 functional review - US has been tested
Every comment is handled - blocking ones have been resolved by reviewer
Design OK
Can be tested by POs
PR was introduced during daily meeting

philippechevieux marked this pull request as draft

January 16, 2025 13:50

philippechevieux force-pushed the feat/XSTREAM-1125-SaturdayNightFeverSidePanel branch 2 times, most recently from 67d94c0 to 6ce3b19 Compare

January 20, 2025 14:51

philippechevieux commented

View reviewed changes

.../components/RecordEdition/EditRecordContent/shared/ValueDetailsBtn/useValueDetailsButton.tsx Outdated Show resolved Hide resolved

philippechevieux commented

View reviewed changes

...c/components/RecordEdition/EditRecordContent/uiElements/StandardField/StandardField.test.tsx Show resolved Hide resolved

philippechevieux commented

View reviewed changes

...ui/src/components/RecordEdition/EditRecordContent/uiElements/StandardField/StandardField.tsx Outdated Show resolved Hide resolved

philippechevieux commented

View reviewed changes

...ui/src/components/RecordEdition/EditRecordContent/uiElements/StandardField/StandardField.tsx Show resolved Hide resolved

philippechevieux commented

View reviewed changes

...rdEdition/EditRecordContent/uiElements/StandardField/StandardFieldValue/DSBooleanWrapper.tsx Show resolved Hide resolved

philippechevieux commented

View reviewed changes

libs/ui/src/components/RecordEdition/EditRecordSidebar/ValueDetails/ValueDetails.tsx Show resolved Hide resolved

philippechevieux commented

View reviewed changes

libs/ui/src/constants.ts Show resolved Hide resolved

philippechevieux marked this pull request as ready for review

January 20, 2025 15:04

philippechevieux changed the title ~~feat(@leav/ui): wip - open value details when user click on input~~ feat(@leav/ui):Open and close the record's value details depending on where the user clicks

renaudAmsellem reviewed

View reviewed changes

...ui/src/components/RecordEdition/EditRecordContent/uiElements/StandardField/StandardField.tsx Outdated Show resolved Hide resolved

P0ppoff reviewed

View reviewed changes

...c/components/RecordEdition/EditRecordContent/uiElements/StandardField/StandardField.test.tsx Show resolved Hide resolved

P0ppoff approved these changes

View reviewed changes

...ui/src/components/RecordEdition/EditRecordContent/uiElements/StandardField/StandardField.tsx Outdated Show resolved Hide resolved

...ition/EditRecordContent/uiElements/StandardField/StandardFieldValue/DSInputNumberWrapper.tsx Show resolved Hide resolved

renaudAmsellem approved these changes

View reviewed changes

...on/EditRecordContent/uiElements/StandardField/StandardFieldValue/ValuesList/DSListSelect.tsx Show resolved Hide resolved

philippechevieux force-pushed the feat/XSTREAM-1125-SaturdayNightFeverSidePanel branch from 84940c0 to 3698256 Compare

January 22, 2025 13:11


          feat(@leav/ui): open and close the record's value details depending o…

03852ef

…n where the user clicks

philippechevieux force-pushed the feat/XSTREAM-1125-SaturdayNightFeverSidePanel branch from 3698256 to 03852ef Compare

January 22, 2025 13:12

philippechevieux merged commit c904144 into develop

26 checks passed

philippechevieux deleted the feat/XSTREAM-1125-SaturdayNightFeverSidePanel branch

January 22, 2025 13:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet